[webkit-reviews] review denied: [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files : [Attachment 140028] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Balazs Ankes
<bank at inf.u-szeged.hu>'s request for review:
Bug 75825: webkit-patch land should automatically add svn:mime-type for .png
files
https://bugs.webkit.org/show_bug.cgi?id=75825

Attachment 140028: proposed fix
https://bugs.webkit.org/attachment.cgi?id=140028&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140028&action=review


This looks pretty good (with the one quibble), but normally we require unit
tests for new code. Can you add some unit tests as well?

> Tools/Scripts/webkitpy/common/checksvnconfigfile.py:46
> +	   return (1, 1, 1)

You should use True/False instead of 1/0.