[webkit-reviews] review granted: [Bug 83572] Height overflow when nesting multiple new Flexbox'es. : [Attachment 140094] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 14:44:44 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 83572: Height overflow when nesting multiple new Flexbox'es.
https://bugs.webkit.org/show_bug.cgi?id=83572
Attachment 140094: Patch
https://bugs.webkit.org/attachment.cgi?id=140094&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140094&action=review
> Source/WebCore/rendering/RenderFlexibleBox.cpp:606
> + return overrideContentLogicalHeight - preferredMainAxisExtent;
Now that all return cases subtract preferredMainAxisExtent, I wonder if we
should rename this method computeMainAxisExtent and subtract
preferredMainAxisExtent in the one calling location.
Up to you.
More information about the webkit-reviews
mailing list