[webkit-reviews] review denied: [Bug 85063] Add low memory check in ExecutableAllocator::underMemoryPressure() : [Attachment 139452] Patch based on Antonio's Comment 15

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Lyon Chen <liachen at rim.com>'s request
for review:
Bug 85063: Add low memory check in ExecutableAllocator::underMemoryPressure()
https://bugs.webkit.org/show_bug.cgi?id=85063

Attachment 139452: Patch based on Antonio's Comment 15
https://bugs.webkit.org/attachment.cgi?id=139452&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139452&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   Call WTF::isSystemMemoryLow() to check whether system memory is low
in
> +	   ExecutableAllocator::underMemoryPressure(). This will force
collecting
> +	   of garbage, thus avoiding out of system memory while at the same
time
> +	   we have a lot of unused memory waiting to be released.

I'm not sure I buy this.  ExecutableAllocator has _nothing_ to do with garbage
collection.  It only deals with JIT memory.  This method returning true should
only cause us to jettison JIT memory; it will not cause any other kinds of
memory reclamation.