[webkit-reviews] review granted: [Bug 85491] MediaStream API: Make PeerConnection00's API fully compliant with the draft : [Attachment 140010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 10:50:36 PDT 2012


Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 85491: MediaStream API: Make PeerConnection00's API fully compliant with
the draft
https://bugs.webkit.org/show_bug.cgi?id=85491

Attachment 140010: Patch
https://bugs.webkit.org/attachment.cgi?id=140010&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140010&action=review


> Source/WebCore/Modules/mediastream/PeerConnection00.cpp:260
> +    if (!ec)
> +	   return;

Is this backwards?  I thought ec == 0 is success.

> LayoutTests/ChangeLog:1
> +2012-05-03  Tommy Widenflycht  <tommyw at google.com>

Looks like this ChangeLog got corrupted a bit.


More information about the webkit-reviews mailing list