[webkit-reviews] review granted: [Bug 85500] REGRESSION(r111387): CSSOM representation of 'background-image' values should be CSSPrimitiveValue. : [Attachment 140042] Patch v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 85500: REGRESSION(r111387): CSSOM representation of 'background-image'
values should be CSSPrimitiveValue.
https://bugs.webkit.org/show_bug.cgi?id=85500

Attachment 140042: Patch v2
https://bugs.webkit.org/attachment.cgi?id=140042&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=140042&action=review


r=me

> Source/WebCore/css/CSSImageValue.cpp:114
> +    RefPtr<CSSPrimitiveValue> uriValue = CSSPrimitiveValue::create(m_url,
CSSPrimitiveValue::CSS_URI);
> +    uriValue->setCSSOMSafe();
> +    return uriValue.release();

This could use a comment about why CSSImageValue gets turned into
CSSPrimitiveValue.