[webkit-reviews] review denied: [Bug 85194] [GTK] Missing WebPreferences for media playback requiring user gestures and inline playback : [Attachment 139466] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Simon Pena
<spena at igalia.com>'s request for review:
Bug 85194: [GTK] Missing WebPreferences for media playback requiring user
gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85194

Attachment 139466: Patch
https://bugs.webkit.org/attachment.cgi?id=139466&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139466&action=review


Looks good. r- only because you don't have commit access yet the documentation
isn't quite clear.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:985
> +    * Whether an user gesture would be required to start media playback or
load
> +    * media. This is off by default, so media playback could start
> +    * automatically. Setting it on requires a gesture by the user to start
> +    * playback, or to load the media.
> +    *

Weird English rules exception nit: Whether an user -> Whether a user 

I think this documentation could be slightly more clear about what kind of
gesture is required to start playback. For instance, if I turn this on, what
will I need to do to trigger playback? Mouse over the page? Mouse over the
element itself? Click on the element?