[webkit-reviews] review canceled: [Bug 76161] [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR. : [Attachment 138178] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 07:47:19 PDT 2012
Philippe Normand <pnormand at igalia.com> has canceled review:
Bug 76161: [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
https://bugs.webkit.org/show_bug.cgi?id=76161
Attachment 138178: Patch
https://bugs.webkit.org/attachment.cgi?id=138178&action=review
------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138178&action=review
> Tools/Scripts/webkitdirs.pm:1846
> + return join(baseProductDir(), "Dependencies");
Hrm. the first argument to join() should be the separator no??
> Tools/Scripts/webkitdirs.pm:1991
> + my $destination = join(getJhbuildPath(), $file);
Ditto.
More information about the webkit-reviews
mailing list