[webkit-reviews] review denied: [Bug 85477] Web Inspector: createRawLocationByURL is too slow if a big number of evals happen. : [Attachment 139990] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 85477: Web Inspector: createRawLocationByURL is too slow if a big number of
evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

Attachment 139990: Patch
https://bugs.webkit.org/attachment.cgi?id=139990&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139990&action=review


> Source/WebCore/inspector/front-end/DebuggerModel.js:226
> +    _resetScriptsMap: function()

_resetScriptsMap -> _resetScriptMaps ?

> Source/WebCore/inspector/front-end/DebuggerModel.js:338
> +	       this._scriptsWithSourceURL[scriptId] = script;

Let's introduce a multimap from source URL to scripts instead to avoid the
linear pass.