[webkit-reviews] review requested: [Bug 84941] [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes : [Attachment 139956] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 84941: [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941

Attachment 139956: Patch
https://bugs.webkit.org/attachment.cgi?id=139956&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
I have fixed the Changelog.

Note - however - that I did not change the type of mime_type struct member:
- The url member in the same struct cannot be changed either and is "const char
*". Unlike the request struct, the response one cannot be changed at all.
- If I change to "const char * const", then this means I need to initialize it
as soon as I create the struct (which is a bit inconvenient). The following
code wouldn't work anymore:

Ewk_Frame_Resource_Response* redirectResponse;
    Ewk_Frame_Resource_Response responseBuffer;
    CString redirectUrl, mimeType;

    if (coreResponse.isNull())
	redirectResponse = 0;
    else {
	redirectUrl = coreResponse.url().string().utf8();
	mimeType = coreResponse.mimeType().utf8();
	responseBuffer.url = redirectUrl.data();
	responseBuffer.status_code = coreResponse.httpStatusCode();
	responseBuffer.mime_type = mimeType.data();
	redirectResponse = &responseBuffer;
    }

    Ewk_Frame_Resource_Messages messages = { &request, redirectResponse };