[webkit-reviews] review granted: [Bug 84899] Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects : [Attachment 139901] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 84899: Add methods to create WebArrayBuffer/WebArrayBufferView from v8
objects
https://bugs.webkit.org/show_bug.cgi?id=84899

Attachment 139901: Patch
https://bugs.webkit.org/attachment.cgi?id=139901&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139901&action=review


> Source/WebKit/chromium/public/WebArrayBuffer.h:71
> +    WEBKIT_EXPORT static WebArrayBuffer* fromV8Value(v8::Handle<v8::Value>);


Can we call this function createFromV8Value to make it clear that this function
allocates memory?

> Source/WebKit/chromium/public/platform/WebArrayBufferView.h:61
> +    WEBKIT_EXPORT static WebArrayBufferView*
fromV8Value(v8::Handle<v8::Value>);

ditto