[webkit-reviews] review denied: [Bug 85399] [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag directly : [Attachment 139877] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 85399: [Chromium] Call addTraceEvent and getTraceCategoryEnabledFlag
directly
https://bugs.webkit.org/show_bug.cgi?id=85399

Attachment 139877: Patch
https://bugs.webkit.org/attachment.cgi?id=139877&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139877&action=review


> Source/WebCore/GNUmakefile.list.am:3583
> -	Source/WebCore/platform/StatsCounter.h \
> +	   Source/WebCore/platform/StatsCounter.h \

This looks wrong.

> Source/WebCore/GNUmakefile.list.am:3658
> +	   Source/WebCore/platform/TraceEventSupport.cpp \
> +	   Source/WebCore/platform/TraceEventSupport.h \

This too.

> Source/WebCore/platform/TraceEventSupport.h:49
> +    static int addTraceEvent(char,
> +				const unsigned char*,
> +				const char*,
> +				unsigned long long,
> +				int,
> +				const char**,
> +				const unsigned char*,
> +				const unsigned long long*,
> +				int,
> +				long long,
> +				unsigned char);

Named args would help, alot.