[webkit-reviews] review granted: [Bug 85411] Opportunistic GC should give up if the Heap is paged out : [Attachment 139914] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 85411: Opportunistic GC should give up if the Heap is paged out
https://bugs.webkit.org/show_bug.cgi?id=85411

Attachment 139914: Patch
https://bugs.webkit.org/attachment.cgi?id=139914&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139914&action=review


R=me with one fix for that comment.

> Source/JavaScriptCore/heap/CopiedSpace.cpp:295
> +	   if (itersSinceLastTimeCheck >= Heap::s_timeCheckResolution) {
> +	       double currentTime = WTF::monotonicallyIncreasingTime();
> +	       if (currentTime > deadline)
> +		   return true;
> +	   }

Shouldn't this be setting itersSinceLastTimeCheck to 0 if we don't return true?