[webkit-reviews] review canceled: [Bug 84317] [chromium] Don't occlude pixels in a surface that are needed for a background filter blur : [Attachment 139666] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 2 16:02:12 PDT 2012
Dana Jansens <danakj at chromium.org> has canceled Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84317: [chromium] Don't occlude pixels in a surface that are needed for a
background filter blur
https://bugs.webkit.org/show_bug.cgi?id=84317
Attachment 139666: Patch
https://bugs.webkit.org/attachment.cgi?id=139666&action=review
------- Additional Comments from Dana Jansens <danakj at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139666&action=review
>> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:159
>> +static inline void reduceOcclusion(const IntRect& affectedArea, const
IntRect& expandedPixel, Region& occlusion)
>
> Some comment about what "expandedPixel" means here would be helpful.
k
>> Source/WebKit/chromium/tests/CCOcclusionTrackerTest.cpp:2759
>> + filters.getOutsets(outsetTop, outsetRight, outsetBottom,
outsetLeft);
>
> You don't seem to use this in this test.
yes thanks, since this is now testing non-reduction instead.
More information about the webkit-reviews
mailing list