[webkit-reviews] review denied: [Bug 85254] PageCache autorelease should not wait until 3 seconds and 42 pages : [Attachment 139566] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 14:40:26 PDT 2012


Brady Eidson <beidson at apple.com> has denied  review:
Bug 85254: PageCache autorelease should not wait until 3 seconds and 42 pages
https://bugs.webkit.org/show_bug.cgi?id=85254

Attachment 139566: the patch
https://bugs.webkit.org/attachment.cgi?id=139566&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Results of new testing not withstanding, this seems too aggressive.

If a call to autorelease comes in during a new page load, we will now be
performing the work of the autorelease while also performing the work of the
new page load.

The user cares about the new page coming in hot, not the old suspended page
being torn down "now"

I think we need to look at this closer.


More information about the webkit-reviews mailing list