[webkit-reviews] review granted: [Bug 85407] webkitpy: Remove direct sys.platform usage in the PNG checker. : [Attachment 139862] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 13:24:41 PDT 2012


Tony Chang <tony at chromium.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 85407: webkitpy: Remove direct sys.platform usage in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85407

Attachment 139862: Patch
https://bugs.webkit.org/attachment.cgi?id=139862&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139862&action=review


> Tools/Scripts/webkitpy/style/checkers/png.py:99
> +	   if not self._platform.is_win():
>	       config_file_path = self._fs.join(self._fs.expanduser("~"),
".subversion/config")
> -	   elif self._platform.startswith('win') or
self._platform.startswith('cygwin'):
> +	   else:
>	       config_file_path = self._fs.join(os.environ['APPDATA'],
"Subversion\config")

Nit: I would put the platform.is_win case first, but this is also fine.


More information about the webkit-reviews mailing list