[webkit-reviews] review granted: [Bug 85392] Fix usage of layout types in platform code : [Attachment 139843] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 85392: Fix usage of layout types in platform code
https://bugs.webkit.org/show_bug.cgi?id=85392

Attachment 139843: Patch
https://bugs.webkit.org/attachment.cgi?id=139843&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139843&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:552
> +    return
enclosingIntRect(m_layerTransform.combined().inverse().clampedBoundsOfProjected
Quad(FloatQuad(FloatRect(m_webGraphicsLayerClient->visibleContentsRect()))));

Longest line ever. :)  I'm surprised the FloatRect() constructor is needed for
this.  Maybe even the FloatQuad() one is implicit too?

> Source/WebKit/chromium/src/WebHitTestResult.cpp:50
> +    return WebPoint(roundedIntPoint(m_private->localPoint()));

Does WebPoint not implicitly construct from IntPoint?

> Source/WebKit/chromium/src/WebSurroundingText.cpp:49
> +    VisiblePosition
visiblePosition(node->renderer()->positionForPoint(static_cast<IntPoint>(hitTes
tInfo.localPoint())));

Does .flooredPoint() not exist?  static_cast seems like an odd way to do this.