[webkit-reviews] review granted: [Bug 85191] MediaStream should not be an ActiveDOMObject : [Attachment 139448] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 09:34:21 PDT 2012

Adam Barth <abarth at webkit.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 85191: MediaStream should not be an ActiveDOMObject

Attachment 139448: Proposed patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139448&action=review

I didn't quite follow all the details in Comment #0, but if you and Tommy agree
that this is the right thing to do, I'm willing to believe it.	:)

> Source/WebCore/ChangeLog:8
> +	   Made MediaStream a ContextDestructionObserver instead.

Consider copying the text from comment #0 in the but to the ChangeLog.	That's
really helpful information and it would be nice to have it in the ChangeLog
rather than a click away in the bug.

More information about the webkit-reviews mailing list