[webkit-reviews] review denied: [Bug 84953] [Qt][WK2] QtWebKit2 doesn't have an API for getting a page source : [Attachment 139810] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jesus
Sanchez-Palencia <jesus at webkit.org>'s request for review:
Bug 84953: [Qt][WK2] QtWebKit2 doesn't have an API for getting a page source
https://bugs.webkit.org/show_bug.cgi?id=84953

Attachment 139810: Patch
https://bugs.webkit.org/attachment.cgi?id=139810&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139810&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1270
> +	   QUrl urlToLoad = d->m_isInViewSourceMode ?
QUrl::fromUserInput(url.toString(QUrl::RemoveScheme)) : url;

The application (say MiniBrowser) should enforce valid urls, not us. You should
just strip it here.