[webkit-reviews] review canceled: [Bug 84953] [Qt][WK2] QtWebKit2 doesn't have an API for getting a page source : [Attachment 139805] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 07:02:39 PDT 2012


Alexis Menard (darktears) <alexis.menard at openbossa.org> has canceled Jesus
Sanchez-Palencia <jesus at webkit.org>'s request for review:
Bug 84953: [Qt][WK2] QtWebKit2 doesn't have an API for getting a page source
https://bugs.webkit.org/show_bug.cgi?id=84953

Attachment 139805: Patch
https://bugs.webkit.org/attachment.cgi?id=139805&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139805&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h:197
> +    bool m_isInViewSourceMode;

Nitpick : Can you move the bool with the other ones so all the bools are
together (maybe one day we can pack all of them).


More information about the webkit-reviews mailing list