[webkit-reviews] review granted: [Bug 85371] Web Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined : [Attachment 139799] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 85371: Web Inspector: TypeError: Cannot call method 'createLiveLocation' of
undefined
https://bugs.webkit.org/show_bug.cgi?id=85371

Attachment 139799: Patch
https://bugs.webkit.org/attachment.cgi?id=139799&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139799&action=review


> Source/WebKit/chromium/ChangeLog:7
> +	   corrent script data which means that context debug id should be
already set on

current or correct ?

> Source/WebKit/chromium/src/WebDevToolsAgentPrivate.h:45
> +    // preprocessing tha should happen before a first script is evaluated in


consider changing to "... that needs to happen before the first script is
evaluated in this context should be done here" ?