[webkit-reviews] review requested: [Bug 78628] perf tests are flaky : [Attachment 139795] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 05:57:02 PDT 2012


Thiago Marcos P. Santos <tmpsantos at gmail.com> has asked  for review:
Bug 78628: perf tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=78628

Attachment 139795: patch
https://bugs.webkit.org/attachment.cgi?id=139795&action=review

------- Additional Comments from Thiago Marcos P. Santos <tmpsantos at gmail.com>
Perf tests are affected by external factors (load, i/o, etc), makes sense to
lock other threads when running them.

This patch solves the problem on my machine of perf tests flaking/timeouting
when building a Debug version of EFL port. IMO we have such a few perf tests
that it is OK to put them on the locked shard, should not affect the total
elapsed time of running layout tests.


More information about the webkit-reviews mailing list