[webkit-reviews] review denied: [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand : [Attachment 139681] Patch-Updated

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis.menard at openbossa.org> has denied Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 27577: [CSS3 Backgrounds and Borders] Add background-size to the background
shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577

Attachment 139681: Patch-Updated
https://bugs.webkit.org/attachment.cgi?id=139681&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139681&action=review


In the same way you also should patch StylePropertySet::getPropertyValue,
StylePropertyShorthand::backgroundShorthand() and CSSComputedStyleDeclaration
and it would be nice to add a test case to cover these cases. You also want to
test other values than initial (well maybe you did but it seemed there was a
problem when you uploaded)

>
LayoutTests/fast/backgrounds/size/backgroundSize-in-background-shorthand-expect
ed.html:16
> +</html>

It doesn't seem to be the right file.