[webkit-reviews] review denied: [Bug 85353] [chromium] Add WebKit API to access inner text value of input element : [Attachment 139771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 02:14:35 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 85353: [chromium] Add WebKit API to access inner text value of input
element
https://bugs.webkit.org/show_bug.cgi?id=85353

Attachment 139771: Patch
https://bugs.webkit.org/attachment.cgi?id=139771&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139771&action=review


> Source/WebKit/chromium/public/WebInputElement.h:78
> +	   WEBKIT_EXPORT WebString innerTextValue() const;
> +	   WEBKIT_EXPORT void setInnerTextValue(const WebString&);

* You should add explanation what is these functions.  It's not clear.

* "innerTextValue" is not a good name for public API. It should be
visibleValue, editingValue, userEditingValue, shownValue, etc.

* If possible, we should avoid to expose setInnerTextValue().  Can you set the
value by editing commands and remove setInnerTextValue()?


More information about the webkit-reviews mailing list