[webkit-reviews] review requested: [Bug 85072] [soup] URL of the ResourceResponse passed to willSendRequest is incorrect : [Attachment 139766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 01:42:52 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 85072: [soup] URL of the ResourceResponse passed to willSendRequest is
incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Attachment 139766: Patch
https://bugs.webkit.org/attachment.cgi?id=139766&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Ok, here is the fixed patch.

2 things I would like to mention:
 - The m_response is now probably updated twice (first in gotHeadersCallback()
when we get the headers and then in sendRequestCallback())
 - Would it make sense to move the WEB_TIMING receiveHeadersEnd update code
from sendRequestCallback() to gotHeadersCallback() now that we listen for the
"got-headers" signal?


More information about the webkit-reviews mailing list