[webkit-reviews] review denied: [Bug 23750] Cannot resize frames because frameborder=0 : [Attachment 139434] Patch to allow resize of frames even in case of frameborder=0. - II

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Swapna
<spottabathini at innominds.com>'s request for review:
Bug 23750: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750

Attachment 139434: Patch to allow resize of frames even in case of
frameborder=0. - II
https://bugs.webkit.org/attachment.cgi?id=139434&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139434&action=review


> Source/WebCore/ChangeLog:9
> +	

Any link to what the spec says about this? I mean there must be a reason for
the original code

> Source/WebCore/rendering/RenderFrameSet.cpp:671
> -    if (split == noSplit || !axis.m_allowBorder[split] ||
axis.m_preventResize[split]) {
> +    if (split == noSplit || axis.m_preventResize[split]) {

Please make sure that this is not breaking frame flattening in any way

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:8
> +	       if (window.layoutTestController)
> +		   layoutTestController.dumpAsText();
> +
> +	       function log(frame, success, isWidth, size) {
> +		 if (window.layoutTestController) {

inconsistent indentation

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:9
> +		   alert(frame.name + ' resized correctly = ' + (success ?
'true' : 'false'));

We normally write PASSED or FAILED, but true, false. Please check how other
tests are made

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:24
> +		   if (!window.layoutTestController)

You have these tests all over. Why not rename init() to run() or so and add
this test as the first thing.

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:30
> +		       //Move the One/* vertical resizer ten pixels west...

Please add a space after // and just one punctuation mark at the end

> LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html:49
> +	       function checkSuccess() {
> +		       log(One, One.frameElement.width == 100, true, 100)
> +		       log(Two, Two.frameElement.height == 80, false, 80)

very inconsistent indentation again