[webkit-reviews] review granted: [Bug 85329] [V8] Add an Isolate parameter to setJSWrapperForXXX() : [Attachment 139718] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 85329: [V8] Add an Isolate parameter to setJSWrapperForXXX()
https://bugs.webkit.org/show_bug.cgi?id=85329

Attachment 139718: Patch
https://bugs.webkit.org/attachment.cgi?id=139718&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139718&action=review


> Source/WebCore/bindings/v8/V8DOMWrapper.h:158
> -    void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object,
v8::Persistent<v8::Object> wrapper)
> +    void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object,
v8::Persistent<v8::Object> wrapper, v8::Isolate* isolate)

If I were writing these patches, I probably would have made v8::Isolate the
first argument to mirror ExecState in JSC, but that probably doesn't play
nicely with having the isolate be optional.