[webkit-reviews] review granted: [Bug 85017] enable ctrl-arrow move by word visually in other platforms (besides Windows) : [Attachment 139671] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 14:25:48 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 85017: enable ctrl-arrow move by word visually in other platforms (besides
Windows)
https://bugs.webkit.org/show_bug.cgi?id=85017

Attachment 139671: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=139671&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139671&action=review


> Source/WebCore/editing/FrameSelection.cpp:645
> +#if !OS(WINCE) && !PLATFORM(QT)
> +	   // Visual word movement relies on isWordTextBreak which is not
implemented in WinCE and QT.

Should we define a new macro like USE(WORD_TEXT_BREAK) ?


More information about the webkit-reviews mailing list