[webkit-reviews] review granted: [Bug 85302] Add support for seamless attribute as well as seamless sandbox flag and default CSS styling : [Attachment 139662] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 85302: Add support for seamless attribute as well as seamless sandbox flag
and default CSS styling
https://bugs.webkit.org/show_bug.cgi?id=85302

Attachment 139662: Patch
https://bugs.webkit.org/attachment.cgi?id=139662&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139662&action=review


> Source/WebCore/ChangeLog:20
> +	   were still to have this seamles styling.  I've added additional
testing for this case.

typo: seamles

> Source/WebCore/html/HTMLIFrameElement.cpp:120
> +    return hasAttribute(seamlessAttr) && contentDocument() &&
contentDocument()->mayDisplaySeamlessWithParent();

Doubt it matters, but you might want to put the hasAttribute check last since
it's slower than the other two null-checks just to be safe.