[webkit-reviews] review denied: [Bug 85101] [chromium] Compute the best target node on a GestureTap event : [Attachment 139661] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 1 13:22:24 PDT 2012
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 85101: [chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101
Attachment 139661: Patch
https://bugs.webkit.org/attachment.cgi?id=139661&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139661&action=review
> Source/WebKit/chromium/src/WebViewImpl.cpp:647
> + WebCore::IntPoint inputPoint(event.x, event.y);
nit: no need for WebCore:: prefix
> Source/WebKit/chromium/src/WebViewImpl.cpp:953
> + || node->hasEventListeners(eventNames().clickEvent)
nit: please indent by four spaces instead of only one
> Source/WebKit/chromium/src/WebViewImpl.h:792
> + RefPtr<WebCore::Node> m_bestTouchTarget;
Why does this need to be a member variable?
More information about the webkit-reviews
mailing list