[webkit-reviews] review granted: [Bug 85301] Crash calling disconnectFrame on a DOMWindowExtension a second time : [Attachment 139657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 12:42:19 PDT 2012


Darin Adler <darin at apple.com> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 85301: Crash calling disconnectFrame on a DOMWindowExtension a second time
https://bugs.webkit.org/show_bug.cgi?id=85301

Attachment 139657: Patch
https://bugs.webkit.org/attachment.cgi?id=139657&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139657&action=review


Is there a way to create a regression test for this?

> Source/WebCore/page/DOMWindowExtension.cpp:60
> +	   ASSERT(!this->frame());

No need for this-> here.


More information about the webkit-reviews mailing list