[webkit-reviews] review granted: [Bug 85296] Allow a pre-targeted node to be specified when dispatching a GestureTap event : [Attachment 139650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 11:44:37 PDT 2012


Adam Barth <abarth at webkit.org> has granted Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 85296: Allow a pre-targeted node to be specified when dispatching a
GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85296

Attachment 139650: Patch
https://bugs.webkit.org/attachment.cgi?id=139650&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139650&action=review


>>> Source/WebCore/ChangeLog:8
>>> +	     No new tests. (OOPS!)
>> 
>> You should remove the 'No new tests' and either add and list tests, or
explain why no new tests were possible.  [changelog/nonewtests] [5]
> 
> The style bot is right.  It doesn't look like anyone calls this function with
this new parameter.  Is this going to be used in the future?

Would you be willing to replace this line with a link to
https://bugs.webkit.org/show_bug.cgi?id=85101 and an explanation that the new
parameter will be used (and hopefully tested!) by that patch?


More information about the webkit-reviews mailing list