[webkit-reviews] review granted: [Bug 84920] Add ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer : [Attachment 139571] Proposed refactoring 2: taking comments into account.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 84920: Add ASSERTs to avoid querying dirtied z-index or normal flow lists
on RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=84920

Attachment 139571: Proposed refactoring 2: taking comments into account.
https://bugs.webkit.org/attachment.cgi?id=139571&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139571&action=review


> Source/WebCore/rendering/RenderLayer.h:933
> +	   ASSERT(!m_negZOrderList || m_negZOrderList->isEmpty());
> +	   ASSERT(!m_posZOrderList || m_posZOrderList->isEmpty());

Can we actually null out m_negZOrderList for non-stacking contexts? I'd prefer
that to be an invariant.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1406
> +    // FIXME: We disable AC for elements in RenderFlowThread as it doesn't
work properly.

I don't like AC used as an abbreviation for accelerated compositing.