[webkit-reviews] review denied: [Bug 85286] [GTK] Compilation warnings in RenderTheme : [Attachment 139639] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 85286: [GTK] Compilation warnings in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=85286

Attachment 139639: Patch
https://bugs.webkit.org/attachment.cgi?id=139639&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139639&action=review


> Source/WebCore/platform/gtk/RenderThemeGtk.cpp:-717
> -    if (fileList->length() == 1) {
> -	   CString systemFilename =
fileSystemRepresentation(fileList->item(0)->path());
> -	   gchar* systemBasename = g_path_get_basename(systemFilename.data());
> -    } else if (fileList->length() > 1)

I'm pretty sure the right thing to do is to actually use the basename of the
file if there is only one of them. It looks like this code now returns
fileButtonNoFilesSelectedLabel. Quite likely you need to add something like
this here:

if (fileList->length())
    string = pathGetFileName(fileList->item(0)->path());