[webkit-reviews] review denied: [Bug 84398] Move LayoutTestController::setValueForUser to Internals : [Attachment 139560] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 02:11:19 PDT 2012


Hajime Morrita <morrita at google.com> has denied Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 84398: Move LayoutTestController::setValueForUser to Internals
https://bugs.webkit.org/show_bug.cgi?id=84398

Attachment 139560: Patch
https://bugs.webkit.org/attachment.cgi?id=139560&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
(In reply to comment #9)
> Clearly I didn't fix the windows linking problem, lets hope I got the gtk one
though.
Your hope didn't come. Good news is that the error message is clear.

  CXXLD  libwebkitgtk-3.0.la
/usr/bin/ld.gold.real: error: ../../Source/autotools/symbols.filter:59:1:
syntax error, unexpected STRING, expecting ';'
/usr/bin/ld.gold.real: fatal error: unable to parse version script file
../../Source/autotools/symbols.filter
collect2: ld returned 1 exit status


More information about the webkit-reviews mailing list