[webkit-reviews] review granted: [Bug 84935] [Chromium/Windows] Add LocalizedDateWin : [Attachment 139583] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 00:20:51 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 84935: [Chromium/Windows] Add LocalizedDateWin
https://bugs.webkit.org/show_bug.cgi?id=84935

Attachment 139583: Patch 3
https://bugs.webkit.org/attachment.cgi?id=139583&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139583&action=review


Looks good to me

> Source/WebCore/ChangeLog:72
> +	   Added. The follwoing functions simply delegate to
LocaleWin::currentLocale().

Nit: follwoing => following

> Source/WebCore/platform/text/LocaleWin.cpp:79
> +    static LocaleWin *currentLocale =
LocaleWin::create(LOCALE_USER_DEFAULT).leakPtr();

Can't we use DEFINE_STATIC_LOCAL()?


More information about the webkit-reviews mailing list