[webkit-reviews] review requested: [Bug 52542] SVG CSS property types with <number> don't support exponents : [Attachment 134986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 31 20:25:49 PDT 2012


Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 52542: SVG CSS property types with <number> don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Attachment 134986: Patch
https://bugs.webkit.org/attachment.cgi?id=134986&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
New approach: Use SVG parser to parse numbers. The logic there is well tested
and has a lot of more checks to make sure that we don't miss a case. Added more
tests for some edge cases as well as overflow tests. isASCIIDigit() and equal
checks prevent us from reading data outside the buffer.


More information about the webkit-reviews mailing list