[webkit-reviews] review granted: [Bug 82839] Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON : [Attachment 134980] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 82839: Generate the flakiness dashboard's list of webkit.org builders from
the buildbot JSON
https://bugs.webkit.org/show_bug.cgi?id=82839

Attachment 134980: Patch
https://bugs.webkit.org/attachment.cgi?id=134980&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134980&action=review


> Tools/TestResultServer/static-dashboards/builders.js:157
> +xhr.onreadystatechange = function() {
> +    if (xhr.readyState == 4) {

Why not just xhr.onload?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:319
> -var PLATFORMS = ['SNOWLEOPARD', 'LEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID',
'APPLE_LEOPARD', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX',
'QT_LINUX'];
> +var PLATFORMS = ['LION', 'SNOWLEOPARD', 'LEOPARD', 'XP', 'VISTA', 'WIN7',
'LUCID', 'APPLE_LION', 'APPLE_LEOPARD', 'APPLE_SNOWLEOPARD', 'APPLE_XP',
'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX'];

What happens when this gets out of sync with the buildbot list of builders?