[webkit-reviews] review denied: [Bug 82778] autofocus should queue a task instead of firing synchronously : [Attachment 134978] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied jochen at chromium.org's request for
review:
Bug 82778: autofocus should queue a task instead of firing synchronously
https://bugs.webkit.org/show_bug.cgi?id=82778

Attachment 134978: Patch
https://bugs.webkit.org/attachment.cgi?id=134978&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134978&action=review


> Source/WebCore/html/HTMLFormControlElement.cpp:209
>	   ref();

No need to ref.

> Source/WebCore/html/HTMLFormControlElement.cpp:515
> +    deref();

No need to deref.

> LayoutTests/fast/events/autofocus-async-expected.txt:2
> +Checks that the focus event triggered by an auto-focused input element is
send asynchronously. The test passes, if "timeout" is printed before "focus".
> +timeout

Instead of saying in which order things should happen, we should verify that in
the test.

> LayoutTests/fast/events/autofocus-async.html:17
> +	   if (window.layoutTestController)
> +	       layoutTestController.notifyDone();

This test is going to timeout if autofocus stopped working.
We should schedule some other event that logs something like "FAIL - never
focused" with non-zero timeout.