[webkit-reviews] review denied: [Bug 82823] [WebSocket]Browser should have platform-specific limitations regarding the frame size : [Attachment 134944] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Li Yin <li.yin at intel.com>'s
request for review:
Bug 82823: [WebSocket]Browser should have platform-specific limitations
regarding the frame size
https://bugs.webkit.org/show_bug.cgi?id=82823

Attachment 134944: Patch
https://bugs.webkit.org/attachment.cgi?id=134944&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134944&action=review


> Source/WebCore/ChangeLog:9
> +	   Protect browser against exhausting its memory, when it reecives a
very big Frame(e.g., of size 2**60).

Typo: reecives.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:87
> +// FIXME: frameSizeLimitation should be platform-specific
> +const size_t frameSizeLimitation = 500 * 1024 * 1024;

This needs an explanation of how each platform would choose the limit. It's not
even clear why a hardcoded limit is appropriate. How was this value chosen, for
example?