[webkit-reviews] review granted: [Bug 82832] CSSStyleRules should own their CSSStyleDeclarations : [Attachment 134961] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 82832: CSSStyleRules should own their CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=82832

Attachment 134961: patch
https://bugs.webkit.org/attachment.cgi?id=134961&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134961&action=review


r=me with some sherlocking.

> Source/WebCore/css/PropertySetCSSStyleDeclaration.h:93
> +    ~StyleRuleCSSStyleDeclaration();

Should be marked virtual.

> Source/WebCore/css/PropertySetCSSStyleDeclaration.h:97
> +    virtual CSSRule* parentRule() const { return m_parentRule;  }
>      virtual void setNeedsStyleRecalc();
>      virtual CSSStyleSheet* contextStyleSheet() const;

We're missing some OVERRIDE decorations here.