[webkit-reviews] review denied: [Bug 82816] presentationAttributeCacheMaximumSize is set too low : [Attachment 134932] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 31 06:57:59 PDT 2012


Antti Koivisto <koivisto at iki.fi> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 82816: presentationAttributeCacheMaximumSize is set too low
https://bugs.webkit.org/show_bug.cgi?id=82816

Attachment 134932: Proposed change.
https://bugs.webkit.org/attachment.cgi?id=134932&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Any long running process will now gather 4096 cache entries wasting non-trivial
amount of memory (in ballpark of ~1MB). I don't think thats acceptable.

I think you should also add a timer based clearing mechanism. If there are no
cache hits for some period of time the cache will get wiped.


More information about the webkit-reviews mailing list