[webkit-reviews] review denied: [Bug 82769] [chromium] Protect CSS filters code with #if ENABLE(CSS_FILTERS). : [Attachment 134863] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 82769: [chromium] Protect CSS filters code with #if ENABLE(CSS_FILTERS).
https://bugs.webkit.org/show_bug.cgi?id=82769

Attachment 134863: Patch
https://bugs.webkit.org/attachment.cgi?id=134863&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
We set ENABLE(CSS_FILTERS) to true in chromium today, right?  Do we ever expect
to set it to false?

I don't personally see much value in guarding chromium-specific code with
ENABLE()s that we know are always going to be true.  For instance, we don't
have any USE(SKIA) guards or ENABLE(WEBGL) guards since we don't support
compiling without those options.  I generally think that's a good thing.