[webkit-reviews] review granted: [Bug 82767] Add a compile assert for the size of InlineFlowBox : [Attachment 134856] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 82767: Add a compile assert for the size of InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=82767

Attachment 134856: Patch
https://bugs.webkit.org/attachment.cgi?id=134856&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134856&action=review


> Source/WebCore/rendering/InlineFlowBox.cpp:50
> +    uint32_t bitfields : 24;

Can we drop the : 24?  It's always going to round up to the packing size,
right?

> Source/WebCore/rendering/InlineFlowBox.h:315
> +    unsigned m_hasAnnotationsBefore : 1;
> +    unsigned m_hasAnnotationsAfter : 1;

Should we add getters and setters for these (I guess to RootInlineBox)?