[webkit-reviews] review granted: [Bug 82766] [BlackBerry] Speed up processing of Selection region generation. : [Attachment 134855] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Mike Fenton <mifenton at rim.com>'s
request for review:
Bug 82766: [BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766

Attachment 134855: Patch
https://bugs.webkit.org/attachment.cgi?id=134855&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134855&action=review


Looks good.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:814
> +    for (unsigned int i = 0; i < rectList.size(); i++) {

Just unsigned is likely enough.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:886
> +	   for (unsigned int i = 0; i < unclippedRegion.numRects(); i++)

Ditto.