[webkit-reviews] review granted: [Bug 82666] Chromium bots should upload archived built files : [Attachment 134837] Fixed

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 82666: Chromium bots should upload archived built files
https://bugs.webkit.org/show_bug.cgi?id=82666

Attachment 134837: Fixed
https://bugs.webkit.org/attachment.cgi?id=134837&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134837&action=review


> Tools/BuildSlaveSupport/built-product-archive:87
> +    for path, dirNames, fileNames in os.walk(directoryToZip):
> +	   relativePath = os.path.relpath(path, directoryToZip)
> +	   for dirName in dirNames:
> +	       archiveZip.write(os.path.join(path, dirName),
os.path.join(relativePath, dirName))

This looks like you're writing directory names only.  I think you can ignore
dirNames and just use fileNames here.  Please test this (you locally modify the
code to run on OSX) before landing.