[webkit-reviews] review granted: [Bug 82745] AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&) : [Attachment 134839] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 82745: AX: Crash at
WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position
const&)
https://bugs.webkit.org/show_bug.cgi?id=82745

Attachment 134839: patch
https://bugs.webkit.org/attachment.cgi?id=134839&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134839&action=review


> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:860
> +    if ([value isKindOfClass:[NSValue class]]) {
> +	   return [NSStringFromRange([value rangeValue]) createJSStringRef];
> +    }

No need for braces here.

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:852
> +    if ([value isKindOfClass:[NSValue class]]) {
> +	   return [NSStringFromRange([value rangeValue]) createJSStringRef];
> +    }

No need for braces here.