[webkit-reviews] review granted: [Bug 76684] Respects font fallback list while webfonts are loading : [Attachment 134751] Use perl instead of python
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 30 10:37:19 PDT 2012
Ojan Vafai <ojan at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76684: Respects font fallback list while webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684
Attachment 134751: Use perl instead of python
https://bugs.webkit.org/attachment.cgi?id=134751&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134751&action=review
> LayoutTests/http/tests/webfont/fallback-font-while-loading.html:23
> + // Set Arial as serif to make sure that the string has different width
when using Ahem and when using serif.
> + layoutTestController.overridePreference('WebKitSerifFont', 'Arial');
Nit: could you just use arial directly as the font-family instead of serif?
> LayoutTests/http/tests/webfont/fallback-font-while-loading.html:37
> +//addTextWithWebfont();
Please delete
More information about the webkit-reviews
mailing list