[webkit-reviews] review denied: [Bug 82735] Web Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameController : [Attachment 134828] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 82735: Web Inspector: [refactoring] factor our frame aggregation logic to
TimelineFrameController
https://bugs.webkit.org/show_bug.cgi?id=82735

Attachment 134828: Patch
https://bugs.webkit.org/attachment.cgi?id=134828&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134828&action=review


It sounds like this change is not only factoring out what is claimed, but makes
random changes to the code. Could you please split it?

> Source/WebCore/ChangeLog:8
> +	   * WebCore.gypi: Added TimelineFrameController.js

Where is the new file?

> Source/WebCore/inspector/front-end/TimelineFrameController.js:52
> +	   this._addRecord(event.data);

Do we need to add this when panel is not shown?

> Source/WebCore/inspector/front-end/TimelineFrameController.js:87
> +	   console.error("shynthetic frame");

Please remove the debug logging.

> Source/WebCore/inspector/front-end/TimelineModel.js:105
> +    var categories = Object.keys(increment);

Please annotate this, btw we do for in all over the place.

> Source/WebCore/inspector/front-end/TimelineModel.js:116
> +    var childrenTime = 0;

Please annotate this.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:-931
> -	   var totalTime = 0;

Where did this method go?

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:885
> +		   if (!longestFrame || longestFrame.cpuTime <
this._frames[currentFrame].cpuTime)

What is longestFrame?