[webkit-reviews] review granted: [Bug 82612] Web Inspector: [Chromium] Implement Chromium-specific part of the device metrics emulation : [Attachment 134825] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 82612: Web Inspector: [Chromium] Implement Chromium-specific part of the
device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82612

Attachment 134825: Patch
https://bugs.webkit.org/attachment.cgi?id=134825&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134825&action=review


> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:183
> +	   m_webView->addPageOverlay(this, 97);

What is 97? We should introduce a common place with these constants.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:221
> +    void autoZoomPageToFitWidth(Frame* frame)

You should have two methods for this.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:356
> +	       m_metricsSupport->restore();

I think you should call restore from destructor.