[webkit-reviews] review denied: [Bug 82733] Web Inspector: undo-ing edit that consists of a Tab does not work. : [Attachment 134820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 30 09:11:44 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 82733: Web Inspector: undo-ing edit that consists of a Tab does not work.
https://bugs.webkit.org/show_bug.cgi?id=82733

Attachment 134820: Patch
https://bugs.webkit.org/attachment.cgi?id=134820&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134820&action=review


> Source/WebCore/inspector/front-end/TextViewer.js:1134
> +	   newRange.startColumn = newRange.endColumn;

I think this is not supposed to happen in some of the code flows above.


More information about the webkit-reviews mailing list